upcoming: [M3-10238] - Review nodebalancers validation schemas#12421
Merged
harsh-akamai merged 9 commits intolinode:developfrom Jul 3, 2025
Merged
Conversation
…ts /v4/nodebalancers & /v4/nodebalancers/configs/{configId}/nodes for NB Dual Stack Support
harsh-akamai
added
the
NB Dual Stack (IPv6)
harsh-akamai
requested review from
hasyed-akamai and
pmakode-akamai
and removed request for
a team
…ps://github.com/harsh-akamai/manager into M3-10238-review-nb-dual-stack-validaion-schemas
hasyed-akamai
approved these changes
Jul 1, 2025
pmakode-akamai
approved these changes
Jul 2, 2025
Comment on lines
62
to
70
| if (isIPv4) { | ||
| if (!PRIVATE_IPV4_REGEX.test(value)) { | ||
| return this.createError({ | ||
| message: PRIVATE_IPV4_WARNING, | ||
| }); | ||
| } else { | ||
| return true; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isIPv4) { | |
| if (!PRIVATE_IPV4_REGEX.test(value)) { | |
| return this.createError({ | |
| message: PRIVATE_IPV4_WARNING, | |
| }); | |
| } else { | |
| return true; | |
| } | |
| } | |
| if (isIPv4) { | |
| if (!PRIVATE_IPV4_REGEX.test(value)) { | |
| return this.createError({ | |
| message: PRIVATE_IPV4_WARNING, | |
| }); | |
| } | |
| return true; | |
| } |
optional nit: We can remove the unnecessary else block to make it a bit cleaner
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts" |
|||||||||||||||||
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Update validation schemas for the changes in POST and PUT endpoints of
/v4/nodebalancers&/v4/nodebalancers/configs/{configdId}/nodesfor NodeBalancer Dual Stack SupportHow to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅